imjoey commented on a change in pull request #1146:
URL: https://github.com/apache/apisix-dashboard/pull/1146#discussion_r549618247
##########
File path: Dockerfile
##########
@@ -16,7 +16,7 @@
#
FROM alpine:latest as pre-build
-ARG APISIX_DASHBOARD_VERSION=v2.0
+ARG APISIX_DASHBOARD_VERSION=master
Review comment:
> Good catch! and should we still keep this file? We have an an-in-one
Dockerfile here[1]. 🤔
>
> cc @membphis @liuxiran @gxthrj @ShiningRush
>
> [1]
https://github.com/apache/apisix-docker/blob/master/all-in-one/apisix-dashboard/Dockerfile
@juzhiyuan that's right. In any case, we'd better not keep two copies for a
single file. The `all-in-one` is better for me (of course, we also need this
patch for that). While, I would say there's one question that's worth noting:
how can we build a docker image for apisix-dashboard continuously once every
single commit gets merged, if using a dockerfile stored in another repository?
Looking forward to your insights. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
