imjoey commented on a change in pull request #1162:
URL: https://github.com/apache/apisix-dashboard/pull/1162#discussion_r550838054
##########
File path: api/build.sh
##########
@@ -20,6 +20,7 @@ export ENV=local
pwd=`pwd`
VERSION=$(cat ./api/VERSION)
+GITHASH=$(cat ./.githash 2> /dev/null || git log --pretty=format:"%h" -1)
Review comment:
@nic-chen BTW, for `git` command is already widely used in `Makefile`,
so I would prefer to keep using `git` to generate git hash into `.githash`.
Please let me know if I was wrong. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
