spacewander commented on a change in pull request #3129:
URL: https://github.com/apache/apisix/pull/3129#discussion_r550857442
##########
File path: apisix/core/utils.lua
##########
@@ -80,28 +82,18 @@ function _M.split_uri(uri)
end
-local function dns_parse(domain, resolvers)
- resolvers = resolvers or _M.resolvers
- local r, err = resolver:new{
- nameservers = table.clone(resolvers),
- retrans = 5, -- 5 retransmissions on receive timeout
- timeout = 2000, -- 2 sec
Review comment:
We should keep the options for the new lua-resty-dns-client way. It
would be better if user can configure them.
##########
File path: rockspec/apisix-master-0.rockspec
##########
@@ -58,6 +58,7 @@ dependencies = {
"resty-redis-cluster = 1.02-4",
"lua-resty-expr = 1.0.0",
"graphql = 0.0.2",
+ "lua-resty-dns-client = 5.1.1-2",
Review comment:
I think it would be safer if we keep two dns client libraries, and use
lua-resty-dns-client by default but provide an option to switch to the old one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
