imjoey opened a new pull request #1203: URL: https://github.com/apache/apisix-dashboard/pull/1203
Signed-off-by: imjoey <[email protected]> Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - Related issues Fixes #1176 . ___ ### Bugfix - Description The empty values of `create_time` and `update_time` should not be returned from server_info interface provided by manager-api . Please see #1176 for details. **Note**: This PR was previously proposed in #1192 , I could not be able to reopen that PR due to my fault operation after closed it. @nic-chen @liuxiran left their opinions, pls see https://github.com/apache/apisix-dashboard/pull/1192/files#issuecomment-753858234 and https://github.com/apache/apisix-dashboard/pull/1192/files#issuecomment-753972035 . Firstly I agreed with @nic-chen and @liuxiran for their perfect solutions for all entities. While after some digs, the perfect solution would bring significant changes to refactor the `BaseInfo` in entities. IMHO, in order to fix #1176 , this PR could also bring an elegant, effective and maintainable way with relatively less cost. @nic-chen @liuxiran , please allow me to reopen this PR to ask for more opinions 😄 , in order to have #1176 fixed in v2.3 release. @membphis @tokers @ShiningRush @juzhiyuan could you pls leave your comments at your convenience. Much appreciated. - How to fix? This PR is going to set `create_time` and `update_time` as `omitempty` to disable JSON serialization when returning back to frontend. In addition, adding the relevant test case for changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
