gxthrj commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r551738522
########## File path: charts/ingress-apisix/templates/deployment.yaml ########## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +apiVersion: apps/v1 +kind: Deployment +metadata: + name: {{ include "ingress-apisix.fullname" . }} + labels: Review comment: should we add namespace: {{ .Release.Namespace }} ? ########## File path: charts/ingress-apisix/templates/tests/test-connection.yaml ########## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +apiVersion: v1 +kind: Pod +metadata: + name: "{{ include "ingress-apisix.fullname" . }}-test-connection" + labels: + {{- include "ingress-apisix.labels" . | nindent 4 }} + annotations: + "helm.sh/hook": test +spec: + containers: + - name: wget + image: busybox + command: ['wget'] + args: ['{{ include "ingress-apisix.fullname" . }}:{{ .Values.service.port }}'] + restartPolicy: Never Review comment: The file is not needed for there is no help for testing. ########## File path: charts/ingress-apisix/values.yaml ########## @@ -0,0 +1,87 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# Default values for ingress-apisix. +# This is a YAML-formatted file. +# Declare variables to be passed into your templates. + +replicaCount: 1 +installCRDs: true + +image: + repository: apache/apisix-ingress-controller + pullPolicy: IfNotPresent + tag: "0.1.0" + +imagePullSecrets: [] +nameOverride: "" +fullnameOverride: "" + +podAnnotations: {} + +podSecurityContext: {} + # fsGroup: 2000 + +securityContext: {} + # capabilities: + # drop: + # - ALL + # readOnlyRootFilesystem: true + # runAsNonRoot: true + # runAsUser: 1000 + +service: + type: ClusterIP + port: 80 + +controller: Review comment: Suggest to set `controller` as the root level, and others should in the subpath. For we need to merged with APISIX helm. Ref to : https://github.com/bitnami/charts/blob/master/bitnami/kong/values.yaml#L150 ########## File path: docs/install.md ########## @@ -54,7 +54,19 @@ kubectl apply -k /path/to/apisix-ingress-controller/samples/deploy ## Helm -// todo +First of all, deploying the necessary CRDs and cluster resources like serviceaccount through the [base](../charts/base) chart. Review comment: I think we do not need to deal with crd and deployment separately. And there are duplicate definitions in _helper.tpl. Because it doesn’t matter if you execute it repeatedly, use helm upgrade when upgrading. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
