tokers commented on a change in pull request #149:
URL:
https://github.com/apache/apisix-ingress-controller/pull/149#discussion_r551748731
##########
File path: test/e2e/scaffold/scaffold.go
##########
@@ -208,3 +210,7 @@ func waitExponentialBackoff(condFunc func() (bool, error))
error {
}
return wait.ExponentialBackoff(backoff, condFunc)
}
+
+func (s *Scaffold) WaitUntilNumPodsCreatedE(selector metav1.ListOptions,
desiredCount int, retries int, interval time.Duration) error {
+ return k8s.WaitUntilNumPodsCreatedE(s.t, s.kubectlOptions, selector,
desiredCount, retries, interval)
Review comment:
`s.WaitUntilNumPodsCreatedE` does nothing but passing parameters to
`k8s. WaitUntilNumPodsCreatedE`, so i think exposing `k8s.
WaitUntilNumPodsCreatedE` is OK. Refactor it until we have to add more logics
for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
