gxthrj commented on a change in pull request #149:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/149#discussion_r551784663



##########
File path: test/e2e/go.mod
##########
@@ -6,12 +6,17 @@ require (
        github.com/gavv/httpexpect/v2 v2.1.0
        github.com/gorilla/websocket v1.4.2 // indirect
        github.com/gruntwork-io/terratest v0.31.2
+       github.com/gxthrj/apisix-ingress-types v0.1.3
+       github.com/gxthrj/apisix-types v0.1.3
+       github.com/gxthrj/seven v0.2.7

Review comment:
       This is a point need to discuss. It will ref to a old seven pkg  in 
go.mod like below:
   `github.com/api7/ingress-controller v0.0.0-20210105024109-72e53386de5a`
   I think we should merge e2e test into ingress project, unify go.mod.
   
   For this PR, I change to `github.com/api7/ingress-controller ` in go.mod .
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to