dabue commented on a change in pull request #3213:
URL: https://github.com/apache/apisix/pull/3213#discussion_r553306137
##########
File path: apisix/balancer.lua
##########
@@ -87,12 +87,17 @@ local function create_checker(upstream, healthcheck_parent)
if healthcheck == nil then
healthcheck = require("resty.healthcheck")
end
- local checker = healthcheck.new({
+ local checker, err = healthcheck.new({
Review comment:
I remember that error happened when more workers tried to create
checkers at the same moment. In the PROD, I have encountered such problems. I
will consider how to add test cases， but I think it's a bit difficult :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
