membphis commented on a change in pull request #1195:
URL: https://github.com/apache/apisix-dashboard/pull/1195#discussion_r554859562
##########
File path: api/test/e2e/route_with_auth_plugin_test.go
##########
@@ -173,4 +174,116 @@ func TestRoute_With_Auth_Plugin(t *testing.T) {
testCaseCheck(tc, t)
}
+ tests = []HttpTestCase{
+ {
+ Desc: "create consumer with jwt (no algorithm)",
+ Object: ManagerApiExpect(t),
+ Path: "/apisix/admin/consumers",
+ Method: http.MethodPut,
+ Body: `{
+ "username":"consumer_1",
+ "desc": "test description",
+ "plugins":{
+ "jwt-auth":{
+ "exp":86400,
+ "key":"user-key",
+ "secret":"my-secret-key"
+ }
+ }
+ }`,
+ Headers: map[string]string{"Authorization": token},
+ ExpectStatus: http.StatusOK,
+ ExpectBody: "\"code\":0",
+ },
+ {
+ Desc: "get the consumer",
+ Object: ManagerApiExpect(t),
+ Path: "/apisix/admin/consumers/consumer_1",
+ Method: http.MethodGet,
+ Headers: map[string]string{"Authorization": token},
+ ExpectStatus: http.StatusOK,
+ ExpectBody: "\"username\":\"consumer_1\"",
+ Sleep: sleepTime,
+ },
+ {
+ Desc: "create the route",
+ Object: ManagerApiExpect(t),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/routes/r1",
+ Body: `{
+ "uri": "/hello",
+ "plugins": {
+ "jwt-auth": {}
+ },
+ "upstream": {
+ "type": "roundrobin",
+ "nodes": [{
+ "host": "172.16.238.20",
+ "port": 1980,
+ "weight": 1
+ }]
+ }
+ }`,
+ Headers: map[string]string{"Authorization": token},
+ ExpectStatus: http.StatusOK,
+ },
+ }
+
+ for _, tc := range tests {
+ testCaseCheck(tc, t)
+ }
+
+ // get the token of jwt
+ basepath := "http://127.0.0.1:9080";
+ request, _ := http.NewRequest("GET",
basepath+"/apisix/plugin/jwt/sign?key=user-key", nil)
+ request.Header.Add("Authorization", token)
+ resp, err := http.DefaultClient.Do(request)
+ assert.Nil(t, err)
+ defer resp.Body.Close()
+ assert.Equal(t, 200, resp.StatusCode)
+ jwttoken, _ := ioutil.ReadAll(resp.Body)
+
+ tests = []HttpTestCase{
+ {
+ Desc: "hit route with jwt token",
+ Object: APISIXExpect(t),
+ Method: http.MethodGet,
+ Path: "/hello",
+ Headers: map[string]string{"Authorization":
string(jwttoken)},
+ ExpectStatus: http.StatusOK,
+ ExpectBody: "hello world",
+ Sleep: sleepTime,
+ },
+ {
+ Desc: "delete consumer",
+ Object: ManagerApiExpect(t),
+ Path: "/apisix/admin/consumers/consumer_1",
+ Method: http.MethodDelete,
+ Headers: map[string]string{"Authorization": token},
+ ExpectStatus: http.StatusOK,
+ ExpectBody: "\"code\":0",
+ },
+ {
+ Desc: "after delete consumer verify it again",
+ Object: ManagerApiExpect(t),
+ Method: http.MethodGet,
+ Path: "/apisix/admin/consumers/jack",
+ Headers: map[string]string{"Authorization": token},
+ ExpectStatus: http.StatusNotFound,
+ Sleep: sleepTime,
+ },
+ {
+ Desc: "delete the route",
+ Object: ManagerApiExpect(t),
+ Method: http.MethodDelete,
+ Path: "/apisix/admin/routes/r1",
+ Headers: map[string]string{"Authorization": token},
+ ExpectStatus: http.StatusOK,
+ },
+ }
+
+ for _, tc := range tests {
+ testCaseCheck(tc, t)
+ }
+
Review comment:
code style: remove this line
##########
File path: api/test/e2e/route_with_auth_plugin_test.go
##########
@@ -17,14 +17,16 @@
package e2e
import (
+ "fmt"
+ "io/ioutil"
"net/http"
"testing"
"time"
"github.com/stretchr/testify/assert"
)
-func TestRoute_With_Auth_Plugin(t *testing.T) {
+func TestRoute_With_Jwt_Plugin(t *testing.T) {
Review comment:
and I think we should update the file name too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
