jenskeiner commented on a change in pull request #3263:
URL: https://github.com/apache/apisix/pull/3263#discussion_r556412344
##########
File path: apisix/plugins/authz-keycloak.lua
##########
@@ -52,8 +55,7 @@ local schema = {
keepalive_timeout = {type = "integer", minimum = 1000, default =
60000},
keepalive_pool = {type = "integer", minimum = 1, default = 5},
ssl_verify = {type = "boolean", default = true},
- },
- required = {"token_endpoint"}
Review comment:
Hmm, I think we should actually use `anyOf` since the explicit endpoint
URL will be preferred if both options are given. The full schema unit test
already uses both options so would have to touch that again as well if we make
this XOR.
I have future dev work in mind that would require using an additional
endpoint. In that case, you may want to use discovery for one endpoint and an
explicit value for the other. But, admittedly, that's a rather strange case. In
any sane environment, you would always use only discovery or only explicit
endpoints, I think.
Let me know your thoughts @spacewander.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
