nic-chen commented on a change in pull request #3224:
URL: https://github.com/apache/apisix/pull/3224#discussion_r559594236



##########
File path: .github/workflows/build.yml
##########
@@ -59,6 +59,15 @@ jobs:
       - name: Linux Before install
         run: sudo ./.travis/${{ matrix.os_name }}_runner.sh before_install
 
+      - name: Start Dubbo Backend
+        if: matrix.os_name == 'linux_openresty'
+        run: |
+          sudo apt install -y maven
+          cd t/lib/dubbo-backend
+          mvn package
+          cd dubbo-backend-provider/target
+          java -Djava.net.preferIPv4Stack=true -jar 
dubbo-demo-provider.one-jar.jar > /tmp/java.log &

Review comment:
       LGTM
   
   It is better to move `t/lib/dubbo-backend` to a separate repo, and only need 
to download the compiled jar when running CI.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to