imjoey opened a new issue #1331:
URL: https://github.com/apache/apisix-dashboard/issues/1331
# Feature request
## Please describe your feature
This issue is originated from discussions with @ShiningRush in #1322 ,
current definition of `Update` methods in Store interface `Update(ctx
context.Context, obj interface{}, createIfNotExist bool) (interface{}, error)`
should be changed to `Update(ctx context.Context, obj interface{},
createIfNotExist bool) error`. The reason is that the input parameter `obj`
already holds the pointer of data that to send back to response, so there's no
need to explicitly return it via the returned parameter `interface{}`.
## Additional context
Current definition of `Create` methods is `Create(ctx context.Context, obj
interface{}) (interface{}, error)`, shall we also refactor it to `Create(ctx
context.Context, obj interface{}) error`? Looking forward to your insights
@ShiningRush , much appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
