spacewander commented on a change in pull request #3332:
URL: https://github.com/apache/apisix/pull/3332#discussion_r560603025
##########
File path: t/config-center-yaml/global-rule.t
##########
@@ -112,3 +112,18 @@ global_rules:
- /h*
#END
--- error_code: 403
+
+
+
+=== TEST 4: common phase without matched route
+--- apisix_yaml
+global_rules:
+ -
+ id: 1
Review comment:
The indentation is correct. The yaml can be parsed correctly.
##########
File path: apisix/init.lua
##########
@@ -598,14 +598,26 @@ local function common_phase(phase_name)
end
if api_ctx.global_rules then
+ local orig_conf_type = api_ctx.conf_type
Review comment:
`orig_` is a common abbr for `original_`, for example:
https://github.com/apache/apisix/blob/15528d815716fa907abd595f989975f12932451a/apisix/core/table.lua#L109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
