tokers commented on a change in pull request #190:
URL:
https://github.com/apache/apisix-ingress-controller/pull/190#discussion_r561669309
##########
File path: Makefile
##########
@@ -58,12 +59,18 @@ unit-test:
go test -cover -coverprofile=coverage.txt ./...
### e2e-test: Run e2e test cases (minikube is required)
-e2e-test: build-image-to-minikube
+e2e-test: build-image-to-minikube ginkgo-check
Review comment:
We may run `ginkgo-check` before `build-image-to-minikube`, it would be
het up if the e2e-test fails after the image was pushed to minikube node but
the `ginkgo` tool is not found.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
