gxthrj commented on a change in pull request #191:
URL:
https://github.com/apache/apisix-ingress-controller/pull/191#discussion_r561908172
##########
File path: test/e2e/scaffold/ingress.go
##########
@@ -29,6 +29,141 @@ import (
const (
_serviceAccount = "ingress-apisix-e2e-test-service-account"
+ _clusterRole = `
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+ name: apisix-view-clusterrole
Review comment:
Need to be combined with namespace.
##########
File path: test/e2e/scaffold/ingress.go
##########
@@ -37,7 +172,7 @@ metadata:
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
- name: cluster-admin
+ name: apisix_view_clusterrole
Review comment:
Need to keep the same as `ClusterRole` (be combined with `namespace`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
