liuxiran commented on a change in pull request #1364:
URL: https://github.com/apache/apisix-dashboard/pull/1364#discussion_r563282078
##########
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##########
@@ -25,6 +25,7 @@ context('Create Route with Upstream', () => {
description: '#desc',
upstreamSelector: '#upstream_id',
searchName: '[title=Name]',
+ custom: '[title=Custom]',
Review comment:
the meaning of `custom` is not very clear IMHO, it would be better to
change a name, e.g: something like `select_upstream` ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
