gxthrj commented on a change in pull request #203:
URL:
https://github.com/apache/apisix-ingress-controller/pull/203#discussion_r563866389
##########
File path: pkg/apisix/cluster.go
##########
@@ -190,6 +190,7 @@ func (c *cluster) syncCacheOnce() (bool, error) {
}
}
for _, s := range ssl {
+ s.FullName = s.ID
Review comment:
Done
##########
File path: pkg/apisix/ssl.go
##########
@@ -168,6 +169,8 @@ func (s *sslClient) Create(ctx context.Context, obj
*v1.Ssl) (*v1.Ssl, error) {
if err != nil {
return nil, err
}
+ ssl.ID = obj.ID
Review comment:
Done
##########
File path: pkg/apisix/ssl.go
##########
@@ -188,6 +191,7 @@ func (s *sslClient) Delete(ctx context.Context, obj
*v1.Ssl) error {
if err := s.cluster.deleteResource(ctx, url); err != nil {
return err
}
+ obj.FullName = obj.ID
Review comment:
Done
##########
File path: pkg/apisix/ssl.go
##########
@@ -228,10 +232,11 @@ func (s *sslClient) Update(ctx context.Context, obj
*v1.Ssl) (*v1.Ssl, error) {
if err != nil {
return nil, err
}
+ ssl.ID = obj.ID
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
