imjoey commented on a change in pull request #1373:
URL: https://github.com/apache/apisix-dashboard/pull/1373#discussion_r564137182
##########
File path: api/go.sum
##########
@@ -339,6 +339,8 @@ github.com/satori/go.uuid v1.2.0/go.mod
h1:dA0hQrYB0VpLJoorglMZABFdXlWrHn1NEOzdh
github.com/sean-/seed v0.0.0-20170313163322-e2103e2c3529/go.mod
h1:DxrIzT+xaE7yg65j358z/aeFdxmN0P9QXhEzd20vsDc=
github.com/shiningrush/droplet v0.2.4
h1:OW4Pp+dXs9O61QKTiYSRWCdQeOyzO1n9h+i2PDJ5DK0=
github.com/shiningrush/droplet v0.2.4/go.mod
h1:akW2vIeamvMD6zj6wIBfzYn6StGXBxwlW3gA+hcHu5M=
Review comment:
@nic-chen It would be better to run `go mod tidy` to prune unused
dependencies. Thanks.
##########
File path: api/test/docker/Dockerfile
##########
@@ -23,8 +23,6 @@ COPY ./ ./
RUN mkdir -p /go/manager-api/conf \
&& mkdir -p /go/manager-api/build-tools \
- && go env -w GOPROXY=https://goproxy.io,direct \
Review comment:
@nic-chen I was wondering that is removing Go proxy related to this PR ?
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
