juzhiyuan commented on a change in pull request #1372:
URL: https://github.com/apache/apisix-dashboard/pull/1372#discussion_r563547766
##########
File path: web/cypress/integration/plugin/create-edit-delete-plugin.spec.js
##########
@@ -39,6 +39,20 @@ context('Create and Delete Plugin List', () => {
cy.configurePlugins(this.cases);
});
+ it('should edit the plugin', () => {
+ cy.visit('/');
+ cy.contains('Plugin').click();
+
+ cy.contains('api-breaker').siblings().contains('Edit').click();
Review comment:
data and domSelector
##########
File path: web/cypress/integration/plugin/create-edit-delete-plugin.spec.js
##########
@@ -70,6 +75,6 @@ context('Create and Delete Plugin List', () => {
});
// check if plugin list is empty
- cy.get(domSelectors.empty);
+ cy.get(domSelector.empty);
Review comment:
get then what? How to check it's empty?
##########
File path: web/cypress/integration/plugin/create-edit-delete-plugin.spec.js
##########
@@ -70,6 +75,6 @@ context('Create and Delete Plugin List', () => {
});
// check if plugin list is empty
- cy.get(domSelectors.empty);
+ cy.get(domSelector.empty);
Review comment:
Don't need `.get().should(xxx)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
