tokers commented on a change in pull request #3417:
URL: https://github.com/apache/apisix/pull/3417#discussion_r564420468
##########
File path: doc/plugin-develop.md
##########
@@ -29,10 +30,39 @@
- [**register public API**](#register-public-api)
- [**register control API**](#register-control-api)
+## where to put your plugin
Review comment:
plugin => plugins.
##########
File path: apisix/cli/ops.lua
##########
@@ -121,6 +122,19 @@ local function version()
end
+local function get_lua_path(conf)
+ if conf then
+ local path = conf
+ if path:byte(-1) ~= str_byte(';') then
+ path = path .. ';'
Review comment:
if conf is `"="`, it'll return `";"`, is this OK for the
`lua_package_path` directive?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
