membphis commented on a change in pull request #3415:
URL: https://github.com/apache/apisix/pull/3415#discussion_r566933233



##########
File path: Makefile
##########
@@ -52,8 +53,16 @@ help: default
 .PHONY: deps
 deps: default
 ifeq ($(LUAROCKS_VER),luarocks 3.)
-       luarocks install --lua-dir=$(LUAJIT_DIR) 
rockspec/apisix-master-0.rockspec --tree=deps --only-deps --local
+       mkdir ~/.luarocks || true
+       luarocks config variables.OPENSSL_LIBDIR $(addprefix $(OR_PREFIX), 
openssl/lib)
+       luarocks config variables.OPENSSL_INCDIR $(addprefix $(OR_PREFIX), 
openssl/include)
+       luarocks install rockspec/apisix-master-0.rockspec --tree=deps 
--only-deps --local
 else
+       @echo "WARN: You're not using LuaRocks 3.x, please add the following 
items to your LuaRocks config file:"

Review comment:
       nice warning




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to