nic-chen commented on a change in pull request #125:
URL: https://github.com/apache/apisix-docker/pull/125#discussion_r568575736
##########
File path: all-in-one/apisix-dashboard/Dockerfile
##########
@@ -23,8 +23,7 @@ RUN set -x \
&& luarocks config variables.OPENSSL_INCDIR
/usr/local/openresty/openssl/include \
&& luarocks install
https://github.com/apache/apisix/raw/master/rockspec/apisix-${APISIX_VERSION}-0.rockspec
--tree=/usr/local/apisix/deps \
&& cp -v
/usr/local/apisix/deps/lib/luarocks/rocks-5.1/apisix/${APISIX_VERSION}-0/bin/apisix
/usr/bin/ \
- && bin='#! /usr/local/openresty/luajit/bin/luajit\npackage.path =
"/usr/local/apisix/?.lua;" .. package.path' \
- && sed -i "1s@.*@$bin@" /usr/bin/apisix \
Review comment:
Would it be better to modify regular expressions than if else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
