spacewander commented on a change in pull request #3197:
URL: https://github.com/apache/apisix/pull/3197#discussion_r569036798
##########
File path: .github/workflows/markdown-link-checker.yml
##########
@@ -1,14 +1,27 @@
name: Check Markdown links
-on: push
+on: [pull_request]
jobs:
markdown-link-check:
- runs-on: ubuntu-latest
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os:
+ - macos-latest
Review comment:
Why it can't read with "ubuntu-latest"?
##########
File path: .github/workflows/markdown-link-checker.yml
##########
@@ -1,14 +1,27 @@
name: Check Markdown links
-on: push
+on: [pull_request]
jobs:
markdown-link-check:
- runs-on: ubuntu-latest
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os:
+ - macos-latest
Review comment:
Why can't it runwith "ubuntu-latest"?
##########
File path: .github/workflows/markdown-link-checker.yml
##########
@@ -1,14 +1,27 @@
name: Check Markdown links
-on: push
+on: [pull_request]
jobs:
markdown-link-check:
- runs-on: ubuntu-latest
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os:
+ - macos-latest
Review comment:
Why can't it run with "ubuntu-latest"?
##########
File path: .github/workflows/markdown-link-checker.yml
##########
@@ -1,14 +1,27 @@
name: Check Markdown links
-on: push
+on: [pull_request]
jobs:
markdown-link-check:
- runs-on: ubuntu-latest
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os:
+ - macos-latest
Review comment:
What error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
