imjoey commented on a change in pull request #1417:
URL: https://github.com/apache/apisix-dashboard/pull/1417#discussion_r569170066
##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -30,6 +30,8 @@ jobs:
run: |
sed -i 's/127.0.0.1:2379/172.16.238.10:2379/' api/conf/conf.yaml
sed -i 's/host: 127.0.0.1/host: 0.0.0.0/' api/conf/conf.yaml
+ sed -i '/172.16.238.11:2379/d' api/conf/conf.yaml
+ sed -i '/172.16.238.12:2379/d' api/conf/conf.yaml
Review comment:
@Jaycean IMHO, there is no need to remove the two lines here, as each
job will be running in independent environment and configurations will not be
affected by others.
@nic-chen what's your opinions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
