gxthrj commented on a change in pull request #1421: URL: https://github.com/apache/apisix-dashboard/pull/1421#discussion_r569979223
########## File path: .github/workflows/make-build.yaml ########## @@ -0,0 +1,31 @@ +name: make build + +on: + push: + branches: + - master + pull_request: + branches: + - master + +jobs: + web-e2e: + name: Frontend e2e test + runs-on: ubuntu-latest + + steps: + - name: Checkout + uses: actions/checkout@v2 + + - name: Setup Node.js environment + uses: actions/[email protected] + with: + node-version: 14.x + + - name: Setup golang environment + uses: actions/[email protected] + with: + go-version: '1.13' + + - name: make build + run: make build Review comment: If an error occurs, it will fail ########## File path: .github/workflows/make-build.yaml ########## @@ -0,0 +1,31 @@ +name: make build + +on: + push: + branches: + - master + pull_request: + branches: + - master + +jobs: + web-e2e: + name: Frontend e2e test + runs-on: ubuntu-latest + + steps: + - name: Checkout + uses: actions/checkout@v2 + + - name: Setup Node.js environment + uses: actions/[email protected] + with: + node-version: 14.x + + - name: Setup golang environment + uses: actions/[email protected] + with: + go-version: '1.13' + + - name: make build + run: make build Review comment: In fact, I did think about it, but cypress is disabled in make build > IMO. Can we put this command at the front e2e test? > Start the manger-api by the binary instead of `go run` ########## File path: .github/workflows/deploy-with-docker.yml ########## @@ -39,7 +39,7 @@ jobs: docker logs docker-deploy_managerapi_1 - name: Run Test - run: api/test/shell/docker_deploy_test.sh + run: api/test/shell/docker_deploy_test.sh -s false Review comment: Done ########## File path: .github/workflows/deploy-with-docker.yml ########## @@ -39,7 +39,7 @@ jobs: docker logs docker-deploy_managerapi_1 - name: Run Test - run: api/test/shell/docker_deploy_test.sh + run: api/test/shell/docker_deploy_test.sh -s false Review comment: Rename to `manager_smoking.sh` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
