Jaycean commented on pull request #1436: URL: https://github.com/apache/apisix-dashboard/pull/1436#issuecomment-774465397
> > ping @nic-chen @starsz @juzhiyuan > > I noticed that in code > > https://github.com/apache/apisix-dashboard/blob/8796fa1b00617f83b495798cc7b86418d1456533/api/internal/handler/ssl/ssl.go#L97-L98 > > > > , the `Key` and `Keys` properties are both set to empty value. This seems to hide private key from users, right? If so, I guess we should also hide them in Create/Update/Patch methods, also needing to update the `giveRet` for unit tests here. Looking forward to your feedbacks. Thanks. > > @Jaycean Could you please set the `Key` and `Keys` to empty values within Create/Update/Patch methods here, just as what's done in Get/List ? Note that also change the relevant unit tests. Thank you very much. OK, I will modify it in this pr. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
