membphis commented on a change in pull request #3530:
URL: https://github.com/apache/apisix/pull/3530#discussion_r571444516
##########
File path: apisix/cli/ops.lua
##########
@@ -279,6 +279,12 @@ Please modify "admin_key" in conf/config.yaml .
end
end
+ if yaml_conf.apisix.dns_resolver_valid then
+ if tonumber(yaml_conf.apisix.dns_resolver_valid) == nil then
Review comment:
I think it is time to do this in this way now
##########
File path: apisix/cli/ops.lua
##########
@@ -279,6 +279,12 @@ Please modify "admin_key" in conf/config.yaml .
end
end
+ if yaml_conf.apisix.dns_resolver_valid then
+ if tonumber(yaml_conf.apisix.dns_resolver_valid) == nil then
Review comment:
I think it is time to do it in this way now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
