imjoey commented on a change in pull request #1436:
URL: https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571541798



##########
File path: api/internal/handler/ssl/ssl.go
##########
@@ -198,7 +198,16 @@ func (h *Handler) Create(c droplet.Context) (interface{}, 
error) {
                return handler.SpecCodeResponse(err), err
        }
 
-       return ret, nil
+       //format respond
+       _ssl := &entity.SSL{}
+       err = utils.ObjectClone(ret, _ssl)

Review comment:
       > > we could directly manipulate the returned value of 
Create/Update/Patch methods without any side effect.
   > 
   > Yes.
   
   Thanks 👍 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to