spacewander commented on a change in pull request #3521:
URL: https://github.com/apache/apisix/pull/3521#discussion_r571572164
##########
File path: .github/workflows/build.yml
##########
@@ -53,6 +53,30 @@ jobs:
with:
submodules: recursive
+ - name: Extract branch name
+ id: branch_env
+ shell: bash
+ run: |
+ export VERSION=${GITHUB_REF##*/}
+ echo "##[set-output name=version;]$(echo ${VERSION:1})"
+ echo "##[set-output name=fullname;]$(echo
apache-apisix-${VERSION:1}-src.tgz)"
+
+ - name: Create tarball
+ # if: ${{ startsWith(github.ref, 'refs/heads/v') &&
!endsWith(matrix.os_name, 'luarocks') }}
+ run: |
+ export VERSION=${{ steps.branch_env.outputs.version }}
+ export RELEASE_SRC=${{ steps.branch_env.outputs.fullname }}
+ make compress-tar
+ # mv release/${RELEASE_SRC} ${RELEASE_SRC}
+ ls
+
+ - name: Remove everything except tarball/.travis/t
Review comment:
Should be `Remove source code`, since we don't remove `.github` either.
##########
File path: .github/workflows/build.yml
##########
@@ -53,6 +53,30 @@ jobs:
with:
submodules: recursive
+ - name: Extract branch name
+ id: branch_env
+ shell: bash
+ run: |
+ export VERSION=${GITHUB_REF##*/}
+ echo "##[set-output name=version;]$(echo ${VERSION:1})"
Review comment:
It seems the output is `erge`? The name should come from the name of
branch. Is it expected?
##########
File path: Makefile
##########
@@ -221,25 +221,7 @@ endif
.travis/openwhisk-utilities/scancode/scanCode.py --config
.travis/ASF-Release.cfg ./
release-src:
Review comment:
Better to use `release-src: compress-tar`
##########
File path: .github/workflows/build.yml
##########
@@ -53,6 +53,30 @@ jobs:
with:
submodules: recursive
+ - name: Extract branch name
+ id: branch_env
+ shell: bash
+ run: |
+ export VERSION=${GITHUB_REF##*/}
+ echo "##[set-output name=version;]$(echo ${VERSION:1})"
+ echo "##[set-output name=fullname;]$(echo
apache-apisix-${VERSION:1}-src.tgz)"
+
+ - name: Create tarball
+ # if: ${{ startsWith(github.ref, 'refs/heads/v') &&
!endsWith(matrix.os_name, 'luarocks') }}
+ run: |
+ export VERSION=${{ steps.branch_env.outputs.version }}
+ export RELEASE_SRC=${{ steps.branch_env.outputs.fullname }}
+ make compress-tar
+ # mv release/${RELEASE_SRC} ${RELEASE_SRC}
+ ls
+
+ - name: Remove everything except tarball/.travis/t
+ # if: ${{ startsWith(github.ref, 'refs/heads/v') &&
!endsWith(matrix.os_name, 'luarocks') }}
Review comment:
We could change the release branch to `release/x.y`, use `release/` as
the prefix.
BTW, is there a way to limit the source of PR to this repo? Only the member
who can create a branch in this repo can trigger the packaging.
##########
File path: .github/workflows/build.yml
##########
@@ -108,3 +132,10 @@ jobs:
- name: Linux Script
run: sudo ./.travis/${{ matrix.os_name }}_runner.sh script
+
+ - name: Publish Artifact
+ # if: ${{ startsWith(github.ref, 'refs/heads/v') &&
!endsWith(matrix.os_name, 'luarocks') }}
Review comment:
We can only upload artifact when `os_name` is linux_openresty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
