Jaycean commented on a change in pull request #1452:
URL: https://github.com/apache/apisix-dashboard/pull/1452#discussion_r571888603
##########
File path: api/internal/handler/upstream/upstream.go
##########
@@ -270,27 +267,15 @@ func (h *Handler) Exist(c droplet.Context) (interface{},
error) {
return nil, err
}
- sort := store.NewSort(nil)
- filter := store.NewFilter([]string{"name", name})
- pagination := store.NewPagination(0, 0)
- query := store.NewQuery(sort, filter, pagination)
- rows := store.NewFilterSelector(toRows(ret), query)
Review comment:
I suggest using a new issue to record this problem. Later, I will check
whether these methods are used in other places, and submit a new PR to delete
them. If my idea is wrong, please correct me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
