juzhiyuan commented on a change in pull request #1472:
URL: https://github.com/apache/apisix-dashboard/pull/1472#discussion_r575801470
##########
File path: web/cypress/integration/user/login.spec.js
##########
@@ -44,4 +44,11 @@ context('Login Test', () => {
cy.contains('Login').click();
cy.get('.ant-notification-notice-message').should('contain',
'Successfully');
});
+
+ it('Press Enter to login success', () => {
Review comment:
```suggestion
it('should press Enter to login successfully', () => {
```
##########
File path: web/cypress/integration/user/login.spec.js
##########
@@ -44,4 +44,11 @@ context('Login Test', () => {
cy.contains('Login').click();
cy.get('.ant-notification-notice-message').should('contain',
'Successfully');
});
+
+ it('Press Enter to login success', () => {
+ cy.visit('/user/Login');
+ cy.get('#control-ref_username').type('user');
Review comment:
dom selector
##########
File path: web/cypress/integration/user/login.spec.js
##########
@@ -44,4 +44,11 @@ context('Login Test', () => {
cy.contains('Login').click();
cy.get('.ant-notification-notice-message').should('contain',
'Successfully');
});
+
+ it('Press Enter to login success', () => {
+ cy.visit('/user/Login');
+ cy.get('#control-ref_username').type('user');
+ cy.get('#control-ref_password').type('user{enter}');
Review comment:
`user{enter}`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
