gxthrj commented on a change in pull request #254:
URL:
https://github.com/apache/apisix-ingress-controller/pull/254#discussion_r577566338
##########
File path: pkg/types/apisix/v1/types.go
##########
@@ -62,6 +62,9 @@ const (
// ActiveHealthCheckMinInterval is the minimum interval for
// the active health check.
ActiveHealthCheckMinInterval = time.Second
+
+ // Default connect, read and send timeout with upstreams.
+ DefaultUpstreamTimeout = 60
Review comment:
Had better add `unit` in comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
