juzhiyuan commented on a change in pull request #3494: URL: https://github.com/apache/apisix/pull/3494#discussion_r580219629
########## File path: doc/plugins/prometheus.md ########## @@ -122,12 +122,56 @@ Or you can goto [Grafana official](https://grafana.com/grafana/dashboards/11719) ### Available metrics -* `Status codes`: HTTP status codes returned by upstream services. These are available per service and across all services. +* `Status`: HTTP status codes returned by upstream services. These are available per service and across all services. Review comment: ```suggestion * `Status`: HTTP status code returned from upstream services. These are available per service and across all services. ``` ########## File path: doc/plugins/prometheus.md ########## @@ -122,12 +122,56 @@ Or you can goto [Grafana official](https://grafana.com/grafana/dashboards/11719) ### Available metrics -* `Status codes`: HTTP status codes returned by upstream services. These are available per service and across all services. +* `Status`: HTTP status codes returned by upstream services. These are available per service and across all services. + + Attributes: + + | Name | Description | + | -------------| --------------------| + | code | The HTTP status code returned by the upstream service. | + | route | The `route_id` of the matched route is requested. If it does not match, the default value is an empty string. | Review comment: > The `route_id` of the matched route is requested requested? ########## File path: doc/plugins/prometheus.md ########## @@ -122,12 +122,56 @@ Or you can goto [Grafana official](https://grafana.com/grafana/dashboards/11719) ### Available metrics -* `Status codes`: HTTP status codes returned by upstream services. These are available per service and across all services. +* `Status`: HTTP status codes returned by upstream services. These are available per service and across all services. Review comment: > These are available per service 🤔 Could this sentence be more clear? ########## File path: doc/plugins/prometheus.md ########## @@ -122,12 +122,56 @@ Or you can goto [Grafana official](https://grafana.com/grafana/dashboards/11719) ### Available metrics -* `Status codes`: HTTP status codes returned by upstream services. These are available per service and across all services. +* `Status`: HTTP status codes returned by upstream services. These are available per service and across all services. + + Attributes: + + | Name | Description | + | -------------| --------------------| + | code | The HTTP status code returned by the upstream service. | Review comment:  Status or Code? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
