Firstsawyou commented on a change in pull request #3512:
URL: https://github.com/apache/apisix/pull/3512#discussion_r582713218
##########
File path: apisix/plugins/traffic-split.lua
##########
@@ -97,7 +97,7 @@ local upstreams_schema = {
items = {
type = "object",
properties = {
- upstream_id = schema_def.id_schema, -- todo: support
upstream_id method
+ upstream_id = schema_def.id_schema,
Review comment:
I think these two methods can be supported at the same time, so that
there is one more option to use upstream and upstream_id in combination. And
the traffic processing between them does not conflict, they are various
independent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
