tokers commented on a change in pull request #3512:
URL: https://github.com/apache/apisix/pull/3512#discussion_r582714377
##########
File path: apisix/plugins/traffic-split.lua
##########
@@ -97,7 +97,7 @@ local upstreams_schema = {
items = {
type = "object",
properties = {
- upstream_id = schema_def.id_schema, -- todo: support
upstream_id method
+ upstream_id = schema_def.id_schema,
Review comment:
Anyway, it's trivial. People don't need two upstream in same block, one
is `upstream`, the other is `upstream_id`, it's confusing if allow them to
coexist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
