batman-ezio commented on pull request #1558:
URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-793201896


   > > > > can we add a logic in create/update API to set the name from url 
params if it does not exists in the request body?
   > > > 
   > > > 
   > > > oh, no, we should not do that.
   > > > we could fix in test cases which do duplicate. I think there will not 
be a lot, because most of test cases will delete the routes at the end.
   > > 
   > > 
   > > ok, can you help to fix the rest test cases, thanks
   > 
   > sure, my pleasure. will update later.
   
   thanks. I have squashed all my test case commits into one commit, and 
rebased from master (which includes the latest frontend e2e fix), but the test 
case still failed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to