This is an automated email from the ASF dual-hosted git repository.

chenjunxu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
     new 6b795db  feat: rewrite e2e test(route_with_uri_uris_test) with ginkgo 
(#1561)
6b795db is described below

commit 6b795db47d44f14ed7327fa30f0027ec266317b2
Author: JinChen <[email protected]>
AuthorDate: Tue Mar 9 12:27:02 2021 +0800

    feat: rewrite e2e test(route_with_uri_uris_test) with ginkgo (#1561)
---
 api/test/e2e/route_with_uri_uris_test.go          | 116 --------------------
 api/test/e2enew/route/route_with_uri_uris_test.go | 127 ++++++++++++++++++++++
 2 files changed, 127 insertions(+), 116 deletions(-)

diff --git a/api/test/e2e/route_with_uri_uris_test.go 
b/api/test/e2e/route_with_uri_uris_test.go
deleted file mode 100644
index 60755a8..0000000
--- a/api/test/e2e/route_with_uri_uris_test.go
+++ /dev/null
@@ -1,116 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package e2e
-
-import (
-       "net/http"
-       "testing"
-)
-
-func TestRoute_with_valid_uri_uris(t *testing.T) {
-       tests := []HttpTestCase{
-               {
-                       Desc:   "add route with valid uri",
-                       Object: ManagerApiExpect(t),
-                       Method: http.MethodPut,
-                       Path:   "/apisix/admin/routes/r1",
-                       Body: `{
-                                       "uri": "/hello",
-                                       "upstream": {
-                                               "type": "roundrobin",
-                                               "nodes": [{
-                                                       "host": "172.16.238.20",
-                                                       "port": 1980,
-                                                       "weight": 1
-                                               }]
-                                       }
-                               }`,
-                       Headers:      map[string]string{"Authorization": token},
-                       ExpectStatus: http.StatusOK,
-               },
-               {
-                       Desc:         "hit the route (r1)",
-                       Object:       APISIXExpect(t),
-                       Method:       http.MethodGet,
-                       Path:         "/hello",
-                       Headers:      map[string]string{"Authorization": token},
-                       ExpectStatus: http.StatusOK,
-                       ExpectBody:   "hello world",
-                       Sleep:        sleepTime,
-               },
-               {
-                       Desc:         "delete the route (r1)",
-                       Object:       ManagerApiExpect(t),
-                       Method:       http.MethodDelete,
-                       Path:         "/apisix/admin/routes/r1",
-                       Headers:      map[string]string{"Authorization": token},
-                       ExpectStatus: http.StatusOK,
-                       Sleep:        sleepTime,
-               },
-               {
-                       Desc:   "add route with valid uris",
-                       Object: ManagerApiExpect(t),
-                       Method: http.MethodPut,
-                       Path:   "/apisix/admin/routes/r1",
-                       Body: `{
-                                       "uris": ["/hello","/status"],
-                                       "upstream": {
-                                               "type": "roundrobin",
-                                               "nodes": [{
-                                                       "host": "172.16.238.20",
-                                                       "port": 1980,
-                                                       "weight": 1
-                                               }]
-                                       }
-                               }`,
-                       Headers:      map[string]string{"Authorization": token},
-                       ExpectStatus: http.StatusOK,
-               },
-               {
-                       Desc:         "hit the route (/hello)",
-                       Object:       APISIXExpect(t),
-                       Method:       http.MethodGet,
-                       Path:         "/hello",
-                       Headers:      map[string]string{"Authorization": token},
-                       ExpectStatus: http.StatusOK,
-                       ExpectBody:   "hello world",
-                       Sleep:        sleepTime,
-               },
-               {
-                       Desc:         "hit the route (/status)",
-                       Object:       APISIXExpect(t),
-                       Method:       http.MethodGet,
-                       Path:         "/status",
-                       Headers:      map[string]string{"Authorization": token},
-                       ExpectStatus: http.StatusOK,
-                       ExpectBody:   "ok",
-                       Sleep:        sleepTime,
-               },
-               {
-                       Desc:         "delete the route (r1)",
-                       Object:       ManagerApiExpect(t),
-                       Method:       http.MethodDelete,
-                       Path:         "/apisix/admin/routes/r1",
-                       Headers:      map[string]string{"Authorization": token},
-                       ExpectStatus: http.StatusOK,
-               },
-       }
-
-       for _, tc := range tests {
-               testCaseCheck(tc, t)
-       }
-}
diff --git a/api/test/e2enew/route/route_with_uri_uris_test.go 
b/api/test/e2enew/route/route_with_uri_uris_test.go
new file mode 100644
index 0000000..640d611
--- /dev/null
+++ b/api/test/e2enew/route/route_with_uri_uris_test.go
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package route
+
+import (
+       "net/http"
+
+       "github.com/onsi/ginkgo"
+       "github.com/onsi/ginkgo/extensions/table"
+
+       "e2enew/base"
+)
+
+var _ = ginkgo.Describe("test route with valid uri uris", func() {
+       table.DescribeTable("test route with valid uri uris",
+               func(tc base.HttpTestCase) {
+                       base.RunTestCase(tc)
+               },
+               table.Entry("add route with valid uri", base.HttpTestCase{
+                       Object: base.ManagerApiExpect(),
+                       Path:   "/apisix/admin/routes/r1",
+                       Method: http.MethodPut,
+                       Body: `{
+                               "uri": "/hello",
+                               "upstream": {
+                                       "nodes": {
+                                               "` + base.UpstreamIp + `:1980": 
1
+                                       },
+                                       "type": "roundrobin"
+                               }
+                       }`,
+                       Headers:      map[string]string{"Authorization": 
base.GetToken()},
+                       ExpectStatus: http.StatusOK,
+               }),
+               table.Entry("hit the route (r1)", base.HttpTestCase{
+                       Object:       base.APISIXExpect(),
+                       Method:       http.MethodGet,
+                       Path:         "/hello",
+                       Headers:      map[string]string{"Authorization": 
base.GetToken()},
+                       ExpectStatus: http.StatusOK,
+                       ExpectBody:   "hello world",
+                       Sleep:        base.SleepTime,
+               }),
+               table.Entry("delete the route (r1)", base.HttpTestCase{
+                       Object:       base.ManagerApiExpect(),
+                       Method:       http.MethodDelete,
+                       Path:         "/apisix/admin/routes/r1",
+                       Headers:      map[string]string{"Authorization": 
base.GetToken()},
+                       ExpectStatus: http.StatusOK,
+                       Sleep:        base.SleepTime,
+               }),
+               table.Entry("hit the route just delete", base.HttpTestCase{
+                       Object:       base.APISIXExpect(),
+                       Method:       http.MethodGet,
+                       Path:         "/hello",
+                       Headers:      map[string]string{"Authorization": 
base.GetToken()},
+                       ExpectStatus: http.StatusNotFound,
+                       ExpectBody:   `{"error_msg":"404 Route Not Found"}`,
+                       Sleep:        base.SleepTime,
+               }),
+               table.Entry("add route with valid uris", base.HttpTestCase{
+                       Object: base.ManagerApiExpect(),
+                       Method: http.MethodPut,
+                       Path:   "/apisix/admin/routes/r1",
+                       Body: `{
+                               "uris": ["/hello","/status"],
+                               "upstream": {
+                                       "type": "roundrobin",
+                                       "nodes": {
+                                               "` + base.UpstreamIp + `:1980": 
1
+                                       }
+                               }
+                       }`,
+                       Headers:      map[string]string{"Authorization": 
base.GetToken()},
+                       ExpectStatus: http.StatusOK,
+               }),
+               table.Entry("hit the route (/hello)", base.HttpTestCase{
+                       Object:       base.APISIXExpect(),
+                       Method:       http.MethodGet,
+                       Path:         "/hello",
+                       Headers:      map[string]string{"Authorization": 
base.GetToken()},
+                       ExpectStatus: http.StatusOK,
+                       ExpectBody:   "hello world",
+                       Sleep:        base.SleepTime,
+               }),
+               table.Entry("hit the route (/status)", base.HttpTestCase{
+                       Object:       base.APISIXExpect(),
+                       Method:       http.MethodGet,
+                       Path:         "/status",
+                       Headers:      map[string]string{"Authorization": 
base.GetToken()},
+                       ExpectStatus: http.StatusOK,
+                       ExpectBody:   "ok",
+                       Sleep:        base.SleepTime,
+               }),
+               table.Entry("delete the route (r1)", base.HttpTestCase{
+                       Object:       base.ManagerApiExpect(),
+                       Method:       http.MethodDelete,
+                       Path:         "/apisix/admin/routes/r1",
+                       Headers:      map[string]string{"Authorization": 
base.GetToken()},
+                       ExpectStatus: http.StatusOK,
+                       Sleep:        base.SleepTime,
+               }),
+               table.Entry("hit the route just delete", base.HttpTestCase{
+                       Object:       base.APISIXExpect(),
+                       Method:       http.MethodGet,
+                       Path:         "/hello",
+                       Headers:      map[string]string{"Authorization": 
base.GetToken()},
+                       ExpectStatus: http.StatusNotFound,
+                       ExpectBody:   `{"error_msg":"404 Route Not Found"}`,
+                       Sleep:        base.SleepTime,
+               }),
+       )
+})

Reply via email to