spacewander commented on a change in pull request #3758:
URL: https://github.com/apache/apisix/pull/3758#discussion_r592841252
##########
File path: apisix/plugins/traffic-split.lua
##########
@@ -309,7 +314,8 @@ function _M.access(conf, ctx)
return
end
- local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj,
weighted_upstreams)
+ local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj,
weighted_upstreams,
Review comment:
The default key should ensure if the configuration of the route changes,
it will change too. So we can ensure either route_upstream_id or
weighted_upstreams changes, the version will change.
The corruption of the route configuration is another story (which should be
fixed)...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
