gxthrj commented on a change in pull request #296:
URL:
https://github.com/apache/apisix-ingress-controller/pull/296#discussion_r592932371
##########
File path: pkg/ingress/controller/controller.go
##########
@@ -137,7 +137,7 @@ func NewController(cfg *config.Config) (*Controller, error)
{
if cfg.Kubernetes.IngressVersion == config.IngressNetworkingV1 {
ingressInformer =
kube.CoreSharedInformerFactory.Networking().V1().Ingresses().Informer()
} else {
- ingressInformer =
kube.CoreSharedInformerFactory.Extensions().V1beta1().Ingresses().Informer()
+ ingressInformer =
kube.CoreSharedInformerFactory.Networking().V1beta1().Ingresses().Informer()
Review comment:
Need to declare the minimum version of k8s supported by Ingress: 1.14 .
Please update the README by the way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
