nic-chen commented on a change in pull request #1592:
URL: https://github.com/apache/apisix-dashboard/pull/1592#discussion_r594248312
##########
File path: api/internal/handler/schema/plugin_test.go
##########
@@ -60,84 +58,9 @@ func TestPlugin(t *testing.T) {
basicAuthConsumerSchema = string(consumerSchemaByte)
assert.Nil(t, err)
}
-
- assert.Contains(t, conf.Plugins, plugin["name"])
}
-
- assert.Contains(t, conf.Plugins, "server-info")
- assert.Contains(t, conf.Plugins, "traffic-split")
- assert.NotContains(t, conf.Plugins, "dubbo-proxy")
-
// plugin type
assert.ElementsMatch(t, []string{"basic-auth", "jwt-auth", "hmac-auth",
"key-auth", "wolf-rbac"}, authPlugins)
// consumer schema
assert.Equal(t,
`{"additionalProperties":false,"properties":{"password":{"type":"string"},"username":{"type":"string"}},"required":["password","username"],"title":"work
with consumer object","type":"object"}`, basicAuthConsumerSchema)
-
Review comment:
move to schema_test.go
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
