spacewander commented on a change in pull request #3831:
URL: https://github.com/apache/apisix/pull/3831#discussion_r594262306



##########
File path: apisix/plugin.lua
##########
@@ -416,6 +416,10 @@ local function merge_service_route(service_conf, 
route_conf)
         new_conf.value.script = route_conf.value.script
     end
 
+    if route_conf.value.name then

Review comment:
       Can we use `new_conf.value.name = route_conf.value.name` directly?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to