gxthrj commented on a change in pull request #152:
URL: https://github.com/apache/apisix-docker/pull/152#discussion_r597449561
##########
File path: compose/dashboard-compose.yaml
##########
@@ -0,0 +1,35 @@
+version: "3"
Review comment:
docker-compose.yaml already have dashboard server, but
`dashboard-compose.yaml` is used to due with the dashbooard-docker-ci, just
like the docker-compose.yaml, they are trigged in different CI concurrently.
##########
File path: Makefile
##########
@@ -20,6 +20,10 @@ APISIX_VERSION ?= 2.4
IMAGE_NAME = apache/apisix
IMAGE_TAR_NAME = apache_apisix
+APISIX_DASHBOARD_VERSION ?= 2.4
+DASHBOARD_IMAGE_NAME = apache/apisix-dashboard
Review comment:
Yep, add prefix is better, added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
