bisakhmondal commented on a change in pull request #1615: URL: https://github.com/apache/apisix-dashboard/pull/1615#discussion_r597597026
########## File path: api/test/e2e/server_info_delete_test.go ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package e2e + +import ( + "net/http" + "testing" +) + Review comment: Hey @starsz, Thanks for the suggestion but no, sadly it won't make any difference. Okay, I am trying my best to explain it again. They way ginkgo works, when we put any `table.Entry` inside `Describe` block, ginkgo internally reduces it the same as `It` block. ginkgo blocks/holds the execution of any tests until it has collected all the `It` blocks and formed a parse tree kind of thing (you can check the behaviour locally by putting a time.Sleep("any large seconds") just after any `ginkgo.Describe` block, not a single test will run until all `It`s are available to be executed on that test suite). All `It` blocks are treated as single individual independent test entities. And then ginkgo runs all the tests (`It` blocks) in parallel/concurrently (in a nutshell, all `table.Entry`s will be run in parallel no matter where we keep it in the test suite). Hope it helps. Thanks again :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
