bisakhmondal commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r598115503
##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -663,6 +663,9 @@ const UpstreamForm: React.FC<Props> = forwardRef(
name: formatMessage({ id:
'page.upstream.step.select.upstream.select.option' }),
id: '',
},
+ {
+ name: formatMessage({ id:
'page.upstream.step.select.upstream.select.none' }),
Review comment:
Hii @stu01509, thanks for the good work :+1: . I'm just curious a bit
about the changes. The generic component UpstreamForm is used by services as we
as other two pages
which includes routes & upstream too. Making a global change to the
component itself will let others select `None` which is not solicited (because
route/upstream with none value doesn't make sense). I may be wrong though, haha.
Hey, guys please confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
