membphis commented on a change in pull request #3824:
URL: https://github.com/apache/apisix/pull/3824#discussion_r599686522



##########
File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua
##########
@@ -46,7 +46,10 @@ local function new_redis_cluster(conf)
                         .. " err: " .. err
         end
 
-        config.serv_list[i] = {ip = host, port = port}
+        config.serv_list[i] = {
+            ip = host, 
+            port = port

Review comment:
       we'd better add a `,` at the end of line

##########
File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua
##########
@@ -65,8 +68,11 @@ function _M.new(plugin_name, limit, window, conf)
     end
 
     local self = {
-        limit = limit, window = window, conf = conf,
-        plugin_name = plugin_name, red_cli =red_cli
+        limit = limit, 
+        window = window, 
+        conf = conf,
+        plugin_name = plugin_name, 
+        red_cli =red_cli

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to