Jaycean commented on a change in pull request #1678:
URL: https://github.com/apache/apisix-dashboard/pull/1678#discussion_r602430807
##########
File path: api/test/e2enew/service/service_test.go
##########
@@ -139,12 +135,11 @@ var _ = ginkgo.Describe("create service without plugin",
func() {
})
})
ginkgo.It("batch test /server_port api", func() {
- t := ginkgo.GinkgoT()
time.Sleep(time.Duration(500) * time.Millisecond)
res := base.BatchTestServerPort(18)
- assert.True(t, res["1980"] == 3)
- assert.True(t, res["1981"] == 6)
- assert.True(t, res["1982"] == 9)
+ gomega.Expect(res["1980"] == 3).Should(gomega.BeTrue())
+ gomega.Expect(res["1981"] == 6).Should(gomega.BeTrue())
+ gomega.Expect(res["1982"] == 9).Should(gomega.BeTrue())
Review comment:
nice suggestions, Thks, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
