Firstsawyou commented on a change in pull request #3925:
URL: https://github.com/apache/apisix/pull/3925#discussion_r603075361
##########
File path: docs/en/latest/plugins/skywalking.md
##########
@@ -92,6 +92,7 @@ We can set the endpoint by specified the configuration in
`conf/config.yaml`.
| service_name | string | "APISIX" | service name for skywalking reporter
|
|service_instance_name|string|"APISIX Instance Name" | service instance name
for skywalking reporter |
| endpoint | string | "http://127.0.0.1:12800" | the http endpoint of
Skywalking, for example: http://127.0.0.1:12800 |
Review comment:
```suggestion
| endpoint_addr | string | "http://127.0.0.1:12800" | the http endpoint
of Skywalking, for example: http://127.0.0.1:12800 |
```
The `endpoint` field name is typo, we should fix it by the way.
##########
File path: docs/zh/latest/plugins/skywalking.md
##########
@@ -96,6 +96,7 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H
'X-API-KEY: edd1c9f034335f1
| service_name | string | "APISIX" | skywalking 上报的 service 名称
|
|service_instance_name|string| "APISIX Instance Name" | skywalking 上报的 service
实例名 |
| endpoint | string | "http://127.0.0.1:12800" | Skywalking 的 HTTP
endpoint 地址,例如:http://127.0.0.1:12800 |
Review comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]