gxthrj commented on a change in pull request #319:
URL:
https://github.com/apache/apisix-ingress-controller/pull/319#discussion_r603331684
##########
File path: test/e2e/ingress/resourcepushing.go
##########
@@ -99,14 +98,56 @@ spec:
err = s.EnsureNumApisixUpstreamsCreated(1)
assert.Nil(ginkgo.GinkgoT(), err, "Checking number of
upstreams")
+ s.NewAPISIXClient().GET("/ip").WithHeader("Host",
"httpbin.com").Expect().Status(http.StatusOK)
+
+ // update
+ apisixRoute = fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
Review comment:
I mean add test cases:
1. In the same `ApisixRoute` yaml ,but change `spec.http.name` when update
2. In the different `ApisixRoute` yaml, but have the same `spec.http.name`,
which means name is conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
