[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1685: docs: tells users where they are

[GitBox]

nic-chen commented on a change in pull request #1685:
URL: https://github.com/apache/apisix-dashboard/pull/1685#discussion_r603704429



##########
File path: web/src/pages/Service/Create.tsx
##########
@@ -116,7 +116,7 @@ const Page: React.FC = (props) => {
     <>
       <PageHeaderWrapper
         title={`${
-          (props as any).match.params.rid
+          (props as any).match.params.serviceId

Review comment:
       > Do we have `serviceId`? cc @nic-chen 
   
   looks like use in creating a service? if yes, we do need it here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org