nic-chen commented on pull request #1689:
URL: https://github.com/apache/apisix-dashboard/pull/1689#issuecomment-810767624


   @iamayushdas 
   
   This is because when verifying the version number, the `.` In `2.4` is used 
as a regular expression to match all strings.
   
   You could submit another commit to avoid this problem.
   
   
   
   To fix this problem, we could change this line of code 
   
https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh#L177
   to :
   
   ```shell
   if [[ `grep -c -w "${VERSION}" ${STDOUT}` -ne '1' ]]; then
   ```
   
   I think you could submit another PR to fix it.
   
   
   Thanks.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to